Some misc client side jQuery fixes#580
Merged
Merged
Conversation
* IIFEs client side to prevent potential and future identifier collisions e.g. "Give a hoot, Don't Pollute" the global content scope unless we plan to support something there or someone else already does. * Some more STYLEGUIDE.md conformance * Some more white-space for readability * Move all view page inline scripts to `.../includes/scripts` where they should be for possible reuse * Always declare `type="text/javascript"` for some older browsers that don't default to JavaScript * Always assume and declare `charset="UTF-8"` for served scripts... our inline scripts should always currently be UTF-8 ... applies to OpenUserJS#200
Martii
added
CODE
Martii
added a commit
that referenced
this pull request
Feb 10, 2015
Some misc client side jQuery fixes Auto-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.../includes/scriptswhere they should be for possible reusetype="text/javascript"for some older browsers that don't default to JavaScriptcharset="UTF-8"for served scripts... our inline scripts should always currently be UTF-8 ... applies to Fix UTF-8 Support #200